chore: fix edition 2024 compile errors #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
commented
Feb 23, 2025
Comment on lines
-143
to
+144
| ref target_schema, | ||
| ref operations, | ||
| target_schema, | ||
| operations, |
There was a problem hiding this comment.
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/standard-xerinae
branch
from
97411cc to
2db0fc0
Compare
xxchan
commented
Feb 23, 2025
| ) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>>>> { | ||
| ) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>> + 'static>> { |
There was a problem hiding this comment.
In edition 2024, the RPIT will capture 'self
And causing error at spawn:
error[E0521]: borrowed data escapes outside of method
--> crates/iceberg/src/scan.rs:402:9
|
365 | pub async fn plan_files(&self) -> Result<FileScanTaskStream> {
| -----
| |
| `self` is a reference that is only valid in the method body
| let's call the lifetime of this reference `'1`
...
402 | / spawn(async move {
403 | | let result = futures::stream::iter(manifest_file_contexts)
404 | | .try_for_each_concurrent(concurrency_limit_manifest_files, |ctx| async move {
405 | | ctx.fetch_manifest_and_stream_manifest_entries().await
... |
412 | | });
| | ^
| | |
| |__________`self` escapes the method body here
| argument requires that `'1` must outlive `'static`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.